RFR: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread [v5]

[Daniel D. Daugherty]

On Thu, 1 Feb 2024 19:18:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix enter_for LockingMode == LM_LEGACY and strengthen assert
>
> src/hotspot/share/runtime/synchronizer.cpp line 1339:
> 
>> 1337: }
>> 1338: 
>> 1339: ObjectMonitor* ObjectSynchronizer::inflate_impl(JavaThread* thread, oop object, const InflateCause cause) {
> 
> I did like the name locking_thread better than just thread.  I see the comment below but I can see also missing the comment and below (it's a long function) deciding that ResourceMark is more efficient when you pass the current thread.  I don't think we managed to rename all "thread" parameter "current" in our cleanups.  Having a longer name makes it more special, which it is.

I'm not fond of `thread` either, but I don't have a better name suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17626#discussion_r1475200216