RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v4]
Boris Ulasevich
bulasevich at openjdk.org
Fri Feb 2 09:33:31 UTC 2024
On Thu, 1 Feb 2024 15:12:49 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> Again. The idea is to move to a plain, simple, readable code, if you don't mind
>
>> Again. The idea is to move to a plain, simple, readable code, if you don't mind
>
> I don't think `subtract_size` is a good name for the function.
> Why does it have three parameters? Logically a subtract operation is `a - b`. A reader of the code will have to go to the definition of the function to understand its logic. This means you can save reader's time just putting the code of `subtract_size` in place or giving more meaningful name.
Right. set_size_of_unset_code_heap name is better. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1475787806
More information about the hotspot-dev
mailing list