RFR: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread [v4]

Richard Reingruber rrich at openjdk.org
Fri Feb 2 16:38:04 UTC 2024


On Fri, 2 Feb 2024 15:18:37 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Axel added that line after my comment.
>
> Thanks for figuring out that's what I was missing! You made the comment, Axel changed
> the code well below your comment in the PR, GitHub didn't connect the comment and
> the code change together to flag anything as "outdated". And most importantly, I missed
> that there was a commit made in response to your comment from the history.

I do find it difficult to follow what's going on once there are more than just a few comments and commits.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17626#discussion_r1476288059


More information about the hotspot-dev mailing list