RFR: 8324983: race in CompileBroker::possibly_add_compiler_threads [v2]

[David Holmes]

On Thu, 1 Feb 2024 17:37:28 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> The number of active compiler threads is decremented before the compiler thread has actually activated so possibly_add_compiler_thread might start a new thread on the existing JavaThread.  This adds a check that it's really exiting before proceeding and some new guarantees that ensure threads aren't started on top running threads.
>
> Tom Rodriguez has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Convert guarantee to assert

Thanks for the update. Thumbs up on the shared changes.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17662#pullrequestreview-1861751213