RFR: 8315762: Update subtype check profile collection on s390x following 8308869 [v2]

Amit Kumar amitkumar at openjdk.org
Mon Feb 5 06:33:07 UTC 2024


On Thu, 25 Jan 2024 15:20:59 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> s390x Implementation for https://github.com/openjdk/jdk/pull/14375
>> 
>> Benchmark Result with patch: 
>> 
>> Benchmark                                         (typePollution)  (typePollutionNotInternalType)   Mode  Cnt     Score    Error   Units
>> RequireNonNullCheckcastScalability.isDuplicated1            false                           false  thrpt   20  1155.409 ± 43.844  ops/us
>> RequireNonNullCheckcastScalability.isDuplicated1            false                            true  thrpt   20   726.923 ± 54.536  ops/us
>> RequireNonNullCheckcastScalability.isDuplicated1             true                           false  thrpt   20   676.462 ± 23.503  ops/us
>> RequireNonNullCheckcastScalability.isDuplicated1             true                            true  thrpt   20   118.650 ±  2.653  ops/us
>> 
>> 
>> Without Patch: 
>> 
>> Benchmark                                         (typePollution)  (typePollutionNotInternalType)   Mode  Cnt     Score     Error   Units
>> RequireNonNullCheckcastScalability.isDuplicated1            false                           false  thrpt   20  1101.248 ± 103.559  ops/us
>> RequireNonNullCheckcastScalability.isDuplicated1            false                            true  thrpt   20   109.690 ±   3.312  ops/us
>> RequireNonNullCheckcastScalability.isDuplicated1             true                           false  thrpt   20   110.790 ±   7.927  ops/us
>> RequireNonNullCheckcastScalability.isDuplicated1             true                            true  thrpt   20   112.244 ±   6.889  ops/us
>> 
>> 
>> Testing : Fastdebug build + tier1 tests
>
> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' of https://git.openjdk.org/jdk into subtype_v0
>  - s390 Port

I ran the test again and didn't see new failure. So moving ahead with integration. 
Thanks @RealLucy @TheRealMDoerr for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17461#issuecomment-1926311491


More information about the hotspot-dev mailing list