RFR: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread [v10]
Axel Boldt-Christmas
aboldtch at openjdk.org
Mon Feb 5 06:51:22 UTC 2024
> The `ObjectSynchronizer` has always assumed that the `current` parameters are both the current thread as well as the thread that is doing the locking. The only time that we are entering on behalf of another thread is when doing re-locking in deoptimization. This has worked because the deoptee thread is suspended. However ResourceMarks have been using the wrong thread when logging is enabled.
>
> This change `ObjectSynchronizer` instruments the relevant methods with both a `JavaThread* locking_thread` as well as `[Java]Thread* current` to be able to use the correct thread for ResourceMarks.
>
> Having the `inflate` care about a `locking_thread` is a little unpleasant in my opinion. But it is required for LM_LIGHTWEIGHT.
> Would probably be cleaner if the inflate for LM_LIGHTWEIGHT was it's own thing, as it does not share the whole INFLATING protocol. But seems like a future RFE to refactor this code.
>
> Can reproduce a crash by modifying `test/jdk/com/sun/jdi/EATests.java` and using `-XX:DiagnoseSyncOnValueBasedClasses=2` with LM_LEGACY or running `test/jdk/com/sun/jdi/EATests.java` with LM_LIGHTWEIGHT/LM_MONITOR and `-Xlog:monitorinflation=trace`.
>
> Could extend this test to capture this regression in the future (or creating a new test based on the same infrastructure). Will give it an attempt, so we have a regression test for this. But these tests get rather involved as the require a lot of jvmti setup.
Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 22 additional commits since the last revision:
- Merge remote-tracking branch 'upstream_jdk/master' into JDK-8324881
- Update comment
- Fix comments
- Update test/jdk/com/sun/jdi/EATests.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Update test/jdk/com/sun/jdi/EATests.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Update test/jdk/com/sun/jdi/EATests.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Update test/jdk/com/sun/jdi/EATests.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Remove newline
- Update src/hotspot/share/runtime/synchronizer.hpp
Co-authored-by: Richard Reingruber <richard.reingruber at sap.com>
- Improve EARelockingNestedInflated_03 for LM_LIGHTWEIGHT
- ... and 12 more: https://git.openjdk.org/jdk/compare/dd3f5d6e...b3cc401c
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17626/files
- new: https://git.openjdk.org/jdk/pull/17626/files/a30e3910..b3cc401c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17626&range=09
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17626&range=08-09
Stats: 2596 lines in 143 files changed: 1531 ins; 324 del; 741 mod
Patch: https://git.openjdk.org/jdk/pull/17626.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17626/head:pull/17626
PR: https://git.openjdk.org/jdk/pull/17626
More information about the hotspot-dev
mailing list