RFR: 8322535: Change default AArch64 SpinPause instruction [v2]
Coleen Phillimore
coleenp at openjdk.org
Tue Feb 6 13:28:05 UTC 2024
On Mon, 5 Feb 2024 15:29:36 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> The Java options OnSpinWaitInst lets you choose which AArch64 instruction should be used in `SpinPause()`. Valid values are "none", "nop", "isb" and "yield". Today the default value for OnSpinWaitInst is unfortunately "none".
>>
>> However some CPUs changes the default SpinPause instruction to something better if the user hasn't used the OnSpinWaitInst option. For instance if you run a Neoverse N1, N2, V1 or V2, the default SpinPause instruction will be changed to "isb". After doing some measurements on Apple's M1-M3 CPUs it also seems like "isb" is the best yielding instruction on on those CPUs.
>>
>> This PR changes the default SpinPause instruction to "yield" on all AArch64 platforms except on Apple's M1, M2 and M3 CPUs on which the default value will be "isb".
>>
>> Tested tier1-tier7 successfully on linux-aarch64 and macosx-aarch64.
>
> Fredrik Bredberg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Removed isb as default SpinPause instruction for Apple silicon
> - Merge branch 'master' into 8322535_default_spinpause_inst
> - Merge branch 'master' into 8322535_default_spinpause_inst
> - 8322535: Change default AArch64 SpinPause instruction
Marked as reviewed by coleenp (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/17430#pullrequestreview-1865164171
More information about the hotspot-dev
mailing list