RFR: 8320302: compiler/arguments/TestC1Globals.java hits SIGSEGV in ContinuationEntry::set_enter_code [v3]

[Patricio Chilano Mateo]

On Tue, 6 Feb 2024 05:15:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8320302
>>  - use vm_exit_during_initialization instead of fatal
>>  - inline call to initialize cont class
>>  - v1
>
> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line 1747:
> 
>> 1745:                                               oop_maps,
>> 1746:                                               exception_offset);
>> 1747:     if (nm == nullptr) vm_exit_during_initialization("Initial size of CodeCache is too small");
> 
> IIUC `AdapterHandlerLibrary::create_native_wrapper`  is the only caller of `generate_native_wrapper` so it is only called during VM init now. But not sure it wouldn't be better/cleaner to simply return nullptr here and have `AdapterHandlerLibrary::create_native_wrapper` do the `vm_exit_during_initialization`?

We could do that too. We have to check for nullptr && method->is_continuation_native_intrinsic() since AdapterHandlerLibrary::create_native_wrapper() itself is called from 2 other places which should not fail with vm_exit_during_initialization() if creation of the native nmethod failed. I don't have a preference, both ways are fine with me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17455#discussion_r1480481182