RFR: 8320646: RISC-V: C2 VectorCastHF2F [v2]

Hamlin Li mli at openjdk.org
Wed Feb 7 15:22:09 UTC 2024


On Wed, 7 Feb 2024 14:49:23 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/assembler_riscv.hpp line 1617:
>> 
>>> 1615:   INSN(vadd_vi,   0b1010111, 0b011, 0b000000);
>>> 1616:   INSN(vrsub_vi,  0b1010111, 0b011, 0b000011);
>>> 1617:   INSN(vnsra_wi,  0b1010111, 0b011, 0b101101);
>> 
>> ~~You can put it up with `vnsra_wx` in the "Vector Narrowing Integer Right Shift Instructions" at https://github.com/openjdk/jdk/pull/17698/files#diff-314214875276cd9a11ecdfd52b68403ded286710ba0820461b0b510506f61a33R1528~~
>
> Let's add a comment to make it more clear what these are
> Suggestion:
> 
> 
>   // Vector Single-Width Floating-Point Add/Subtract Instructions
>   INSN(vnsra_wi,  0b1010111, 0b011, 0b101101);

Thanks, it's done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17698#discussion_r1481639709


More information about the hotspot-dev mailing list