RFR: 8320750: Allow a testcase to run with multiple -Xlog [v2]

Stefan Karlsson stefank at openjdk.org
Thu Feb 8 09:06:59 UTC 2024


On Thu, 8 Feb 2024 06:39:33 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added test, reworked code structure after suggestions from Stefan and Johan
>
> test/jtreg-ext/requires/VMProps.java line 727:
> 
>> 725:      * Split an -Xflag string into a name part (without leading dash)
>> 726:        and a value part ("true" if no value was given)
>> 727:      */
> 
> May I suggest sparing the reader some effort and adding a couple of examples e.g.:
> 
> -Xmx4g => (Xmx, 4g)
> -Xcheck:jni => (Xcheck, :jni)
> -Xbootclasspath/a:<path> => (Xbootclasspath, /a:<path>)

The last example is interesting. Is it supposed to be:

-Xbootclasspath/a:<path> => (Xbootclasspath, /a:<path>

or should it be:

-Xbootclasspath/a:<path> => (Xbootclasspath/a, <path>)

I think it should be the latter and if that's the case then the regex should be updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16824#discussion_r1482609140


More information about the hotspot-dev mailing list