RFR: JDK-8325264: two compiler/intrinsics/float16 tests fail after JDK-8324724 [v2]

[Bhavana Kilambi]

On Thu, 8 Feb 2024 11:04:51 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

>> src/hotspot/share/runtime/stubRoutines.hpp line 457:
>> 
>>> 455:   static jshort f2hf(jfloat x) {
>>> 456:     MACOS_AARCH64_ONLY(ThreadWXEnable wx(WXExec, Thread::current());) // About to call into code cache
>>> 457:     assert(_f2hf != nullptr, "stub is not implemented on this platform");
>> 
>> Would it make sense to have the assert as first thing in the method?
>
> Yes, probably a better idea to make sure the address (of the stub) being accessed is valid before making that memory region executable. Will make changes and update. Thanks!

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17733#discussion_r1483560838