RFR: JDK-8325264: two compiler/intrinsics/float16 tests fail after JDK-8324724 [v2]
Tobias Hartmann
thartmann at openjdk.org
Fri Feb 9 10:17:04 UTC 2024
On Thu, 8 Feb 2024 20:37:07 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:
>> Fix for two JTREG test failures on OS_X after this commit - https://github.com/openjdk/jdk/commit/51853f7488afa69c0d14b0e96f1da84822cd83f1.
>>
>> This is due to no permission to execute the stub code in the code cache. This patch fixes this problem by acquiring "WXExec" to be able to execute the instructions in code cache.
>>
>> Both the tests - compiler/intrinsics/float16/TestAllFloat16ToFloat.java and compiler/intrinsics/float16/Binary16ConversionNaN.java pass on a MacOS machine.
>
> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>
> Make assert the first statement in the function
Yes, all tests passed. This is good to go.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17733#issuecomment-1935657528
More information about the hotspot-dev
mailing list