RFR: 8319801: Recursive lightweight locking: aarch64 implementation [v16]

Axel Boldt-Christmas aboldtch at openjdk.org
Thu Feb 15 10:15:06 UTC 2024


On Thu, 15 Feb 2024 09:33:08 GMT, Andrew Haley <aph at openjdk.org> wrote:

> These are both misleading to the reader. Sure, they're cute, but they're dangerous, as has proved in practice several times in the AArch64 port. Writing a `mov` that is known to do nothing is severely misleading. It can be mitigated with a "this mov does nothing" comment.

I suspected that this interpretation of what you was asking was incorrect, but wanted to clarify. 

> A prefix naming convention is a significant improvement

I will go ahead with this approach then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16608#discussion_r1490758797


More information about the hotspot-dev mailing list