RFR: 8325932: Replace ATTRIBUTE_NORETURN with direct [[noreturn]]

[Rémi Forax]

On Thu, 15 Feb 2024 09:10:51 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> With clang 13 being the minimum required JDK-8325878, the noreturn bug that requires the ATTRIBUTE_NORETURN workaround now vanishes, and we can use [[noreturn]] directly within HotSpot. We should remove the workaround as soon as possible, given the chance

I believe "as soon as possible" should be "once JDK-8325878 is resolved" :)

Now, the reason to use [[noreturn]] instead of ATTRIBUTER_NORETURN macro is that IDEs recognize [[noreturn]] when doing static analysis on the code and that ATTRIBUTER_NORETURN was added as a workaround because a bug (crash) in clang < 12.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17868#issuecomment-1946562523