RFR: 8317697: refactor-encapsulate x86 VM_Version::CpuidInfo [v4]
Vladimir Kozlov
kvn at openjdk.org
Thu Feb 15 20:36:58 UTC 2024
On Thu, 15 Feb 2024 12:18:17 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:
>> In OpenJDK project CRaC I had a [need to fetch new CpuidInfo without affecting the existing one](https://github.com/openjdk/crac/commit/ed4ad9ba31b77732dcede2eb743b2f389ec9a0fe#diff-6ed856c57ddbe33e49883adb7c52ec51ed377e5f697dfd6d8bea505a97bfc5a5R2743).
>> Which led me to encapsulate the object more and I think this no-functionality-change patch is even appropriate for JDK.
>> I am sure interested primarily to reduce the CRaC patchset boilerplate.
>
> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - Merge branch 'master' into flagsencaps
> - Remove the automatic zero-initialization
> - Make CpuidInfo a class
> - Merge branch 'master' into flagsencaps
> - 8317697: refactor-encapsulate x86 VM_Version::CpuidInfo
Looks hood to me too.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16093#pullrequestreview-1883825212
More information about the hotspot-dev
mailing list