RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v6]
Evgeny Astigeevich
eastigeevich at openjdk.org
Thu Feb 15 22:56:57 UTC 2024
On Fri, 2 Feb 2024 09:33:31 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
>> These changes clean up the logic and the code of allocating codecache segments and add more testing of it, to open a door for further optimization of code cache segmentation. The goal was to keep the behavior as close to the existing behavior as possible, even if it's not quite logical.
>>
>> Also, these changes better account for alignment - PrintFlagsFinal shows the final aligned segment sizes, and the segments fill the ReservedCodeCacheSize without gaps caused by alignment.
>
> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
>
> set_size_of_unset_code_heap
src/hotspot/share/code/codeCache.cpp line 205:
> 203:
> 204: err_msg message("NonNMethodCodeHeapSize (" SIZE_FORMAT "K)", non_nmethod.size/K);
> 205: if (profiled.enabled) {
Is `profiled.size` zero if `profiled.enabled` is false?
If so, we can just pass: total and sizes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1491758668
More information about the hotspot-dev
mailing list