RFR: 8325095: C2: bailout message broken: ResourceArea allocated string used after free [v2]
Thomas Stuefe
stuefe at openjdk.org
Fri Feb 16 12:37:56 UTC 2024
On Fri, 16 Feb 2024 09:35:23 GMT, Dean Long <dlong at openjdk.org> wrote:
>> I think initially we care only about "most" important failure because implementation allowed to report only one failure.
>> If you can keep all failures AND report all of them it would be nice, I think. May be in separate RFE.
>>
>> We should have only one place where we keep failures.
>
> Reporting all failures might make sense for logging, but we can only report one reason, unless we want to do something like chained exceptions, which I don't think we need. The different layers is already looking like a custom exception handling mechanism, unfortunately.
Piling on... I opt for keeping this code simple. A list of subsequent failure states could easily be part of logging.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17710#discussion_r1492391705
More information about the hotspot-dev
mailing list