RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v8]

[Evgeny Astigeevich]

On Tue, 20 Feb 2024 13:26:22 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

>> These changes clean up the logic and the code of allocating codecache segments and add more testing of it, to open a door for further optimization of code cache segmentation.  The goal was to keep the behavior as close to the existing behavior as possible, even if it's not quite logical.
>> 
>> Also, these changes better account for alignment - PrintFlagsFinal shows the final aligned segment sizes, and the segments fill the ReservedCodeCacheSize without gaps caused by alignment.
>
> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   one another cleanup round

src/hotspot/share/code/codeCache.cpp line 227:

> 225:   if (!heap_available(CodeBlobType::MethodNonProfiled)) {
> 226:     assert(false, "MethodNonProfiled heap is always available for segmented code heap");
> 227:   }

It's just:

assert(heap_available(CodeBlobType::MethodNonProfiled), "MethodNonProfiled heap must be always available for segmented code heap");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1496562558