RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v8]
Evgeny Astigeevich
eastigeevich at openjdk.org
Tue Feb 20 22:24:58 UTC 2024
On Tue, 20 Feb 2024 13:26:22 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
>> These changes clean up the logic and the code of allocating codecache segments and add more testing of it, to open a door for further optimization of code cache segmentation. The goal was to keep the behavior as close to the existing behavior as possible, even if it's not quite logical.
>>
>> Also, these changes better account for alignment - PrintFlagsFinal shows the final aligned segment sizes, and the segments fill the ReservedCodeCacheSize without gaps caused by alignment.
>
> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
>
> one another cleanup round
src/hotspot/share/code/codeCache.cpp line 275:
> 273: check_min_size("profiled code heap", profiled.size, min_size);
> 274: }
> 275: if (non_profiled.enabled) {
It's redundant because it is always true.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1496611416
More information about the hotspot-dev
mailing list