RFR: 8139457: Relax alignment of array elements [v23]

Coleen Phillimore coleenp at openjdk.org
Tue Feb 20 23:58:08 UTC 2024


On Wed, 15 Feb 2023 14:51:19 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clarify comment on arrayOopDesc::max_array_length()
>
> src/hotspot/share/opto/type.cpp line 5010:
> 
>> 5008:   if( _offset != 0 ) {
>> 5009:     BasicType basic_elem_type = elem()->basic_type();
>> 5010:     int header_size = arrayOopDesc::base_offset_in_bytes(basic_elem_type);
> 
> This function now calls base_offset_in_bytes twice. One to set header_size and the other to set the array_base. Maybe clean that up?

At line 5181. re: Stefan's comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11044#discussion_r1492437784


More information about the hotspot-dev mailing list