RFR: 8324833: Signed integer overflows in ABS [v5]

Aleksey Shipilev shade at openjdk.org
Thu Feb 22 08:53:24 UTC 2024


> See the details in the bug. I think current `ABS` implementation is beyond repair, and we should just switch to `uabs`.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug, `all` with `-ftrapv` (now fully passes!)
>  - [x] Linux x86_64 fastdebug, `all`

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

  Fix a place where we cast to jlong after uabs

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17617/files
  - new: https://git.openjdk.org/jdk/pull/17617/files/272fb16b..b9422420

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17617&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17617&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17617.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17617/head:pull/17617

PR: https://git.openjdk.org/jdk/pull/17617


More information about the hotspot-dev mailing list