RFR: 8139457: Relax alignment of array elements [v66]

Roman Kennke rkennke at openjdk.org
Thu Feb 22 13:10:11 UTC 2024


On Thu, 22 Feb 2024 12:46:15 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move shim into initialize_header()
>
> src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp line 195:
> 
>> 193:       xorl(t1, t1);
>> 194:       movl(Address(obj, arrayOopDesc::length_offset_in_bytes() + BytesPerInt), t1);
>> 195:     }
> 
> There's two `arrayOopDesc::length_offset_in_bytes() + BytesPerInt` calculations in this block. Wouldn't it be better to use `base_offset` instead of the second calculation?

Right. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11044#discussion_r1499215319


More information about the hotspot-dev mailing list