RFR: 8322179: RISC-V: Implement SHA-1 intrinsic [v10]

Hamlin Li mli at openjdk.org
Fri Feb 23 11:30:07 UTC 2024


On Fri, 23 Feb 2024 10:51:48 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Seems not, as cur_k is only calculated when `(round % 20) == 0`.
>> 
>> Other comments are all resolved.
>
> Thanks. Could you please move `int round` as the last formal param for other assembler functions so that it will be more consistent? They are `sha1_prepare_w`, `sha1_f`, and `sha1_process_round`. BTW: I think it will be safer to add scratch register `t0`, `t1` to the list for `assert_different_registers` if they are used in those assembler functions.

Sure, it's updated. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17130#discussion_r1500534552


More information about the hotspot-dev mailing list