RFR: 8325095: C2: bailout message broken: ResourceArea allocated string used after free [v2]
Vladimir Kozlov
kvn at openjdk.org
Fri Feb 23 18:33:56 UTC 2024
On Fri, 23 Feb 2024 08:49:47 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>About Logging, in a future RFE:
@vnkozlov suggested to always UL failures immediately. The question is where I should do that. At ciEnv::record_method_not_compilable only? Or also in Compile::record_method_not_compilable?
`Compile::record_method_not_compilable()` calls `ciEnv::record_method_not_compilable()` so you need only add it to ciEnv.
>And @vnkozlov also suggested only to report one (a single) failure reason at the very end, presumably at the CompileTask level. Does that mean you would still overwrite the less important failures with more important ones in ciEnv, like we do currently?
I suggest to leave the normal report code as it is now (one failure). And if we need additional information we will use UL when we implement it.
Most ciEnv failures are recorded (`record_failure`) during publishing compiled code in `ciEnv::register_method()` after compilation is done and it did not have failures.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17710#issuecomment-1961804948
More information about the hotspot-dev
mailing list