RFR: 8322179: RISC-V: Implement SHA-1 intrinsic [v13]

[Hamlin Li]

On Fri, 23 Feb 2024 22:16:21 GMT, Antonios Printezis <tonyp at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   assert register; move round param
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4856:
> 
>> 4854:     if (round == 16) {
>> 4855:       int64_t block_bytes = round * 4;
>> 4856:       __ addi(buf, buf, block_bytes);
> 
> Does `buf` need to be incremented here? And why at `round == 16` and not after all the rounds are done? Maybe you can do this in the loop in `generate_sha1_implCompress` to have the code that initializes and increments it in the same function? Also, does it need to be incremented if `!multi_block`?

Thanks, Good catch!

And other comments are also resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17130#discussion_r1502372429