RFR: 8320646: RISC-V: C2 VectorCastHF2F [v2]
Ludovic Henry
luhenry at openjdk.org
Tue Feb 27 14:50:45 UTC 2024
On Wed, 7 Feb 2024 15:22:09 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you review this patch to add instrinsics for VectorCastHF2F/VectorCastF2HF?
>> Thanks!
>>
>> ## Test
>>
>> test/jdk/java/lang/Float/Binary16ConversionNaN.java
>> test/jdk/java/lang/Float/Binary16Conversion.java
>>
>> hotspot/jtreg/compiler/intrinsics/float16
>> hotspot/jtreg/compiler/vectorization/TestFloatConversionsVectorjava
>> hotspot/jtreg/compiler/vectorization/TestFloatConversionsVectorNaN.java
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>
> add some comments
Changes requested by luhenry (Committer).
src/hotspot/cpu/riscv/globals_riscv.hpp line 117:
> 115: product(bool, UseZihintpause, false, EXPERIMENTAL, \
> 116: "Use Zihintpause instructions") \
> 117: product(bool, UseZvfh, false, "Use Zvfh instructions") \
If adding this flag, please mark as experimental as there is currently no hardware we can test that on (other than QEMU).
-------------
PR Review: https://git.openjdk.org/jdk/pull/17698#pullrequestreview-1903725178
PR Review Comment: https://git.openjdk.org/jdk/pull/17698#discussion_r1504362532
More information about the hotspot-dev
mailing list