RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v5]
David Holmes
dholmes at openjdk.org
Wed Feb 28 04:09:44 UTC 2024
On Tue, 27 Feb 2024 21:46:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been integrated, it is possible to do some cleanup. The goal of [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change any behavior, even if that behavior seemed odd.
>>
>> Now let's try to fix that. We can:
>>
>> a) remove JNIEXPORT from c2v functions.
>> b) make debug.cpp functions exported similarly on all platforms.
>> c) remove JNIEXPORT from aarch64 asm debug function.
>>
>> Note that this PR is [dependent on](https://mail.openjdk.org/pipermail/jdk-dev/2021-March/005232.html) https://github.com/openjdk/jdk/pull/17955.
>
> Magnus Ihse Bursie has updated the pull request incrementally with three additional commits since the last revision:
>
> - Why did these creep back in? Merge error?
> - Remove #undef JNIEXPORT
> - Remove das1()
Seems fine to me. Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17967#pullrequestreview-1905265100
More information about the hotspot-dev
mailing list