RFR: 8318302: ThreadCountLimit.java failed with "Native memory allocation (mprotect) failed to protect 16384 bytes for memory to guard stack pages" [v3]
Aleksey Shipilev
shade at openjdk.org
Wed Feb 28 08:03:53 UTC 2024
On Wed, 28 Feb 2024 02:53:39 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/Thread/ThreadCountLimit.java line 82:
>>
>>> 80: String java_cmd = ProcessTools.getCommandLine(pb);
>>> 81: // Relaunch the test with args.length > 0, and the ulimit set
>>> 82: ProcessTools.executeCommand("bash", "-c", ULIMIT_CMD + " && " + java_cmd + " dummy")
>>
>> I think this assumes `bash` is installed, which is true 99% of the time, but not actually guaranteed. Maybe we should check `if (Platform.isLinux() && new File("/bin/bash").exists())` explicitly.
>
> @shipilev do you want this explored further?
Not really. We can fix the test if bash-ism manifests as the problem.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17959#discussion_r1505511170
More information about the hotspot-dev
mailing list