RFR: 8320646: RISC-V: C2 VectorCastHF2F [v2]

Hamlin Li mli at openjdk.org
Wed Feb 28 14:19:06 UTC 2024


On Tue, 27 Feb 2024 08:46:04 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add some comments
>
> src/hotspot/cpu/riscv/riscv_v.ad line 3706:
> 
>> 3704:   match(Set dst (VectorCastF2HF src));
>> 3705:   effect(TEMP_DEF dst, TEMP v0, TEMP tmp);
>> 3706:   format %{ "vfncvt.f.f.w $dst, $src\t# convert single to half precision"
> 
> Unnecessary new-line:
> Suggestion:
> 
>   format %{ "vfwcvt.f.f.v $dst, $src\t# convert half to single precision" %}

fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17698#discussion_r1506034334


More information about the hotspot-dev mailing list