RFR: 8324829: Uniform use of synchronizations in NMT

Afshin Zafari azafari at openjdk.org
Thu Feb 29 08:41:54 UTC 2024


On Tue, 27 Feb 2024 05:48:36 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>>> > @afshin-zafari  Please, set correct RFE id number!!!!  See "Integration blockers" and "Issue".
>>> 
>>> ow. But Skara bot did not catch this? How strange.
>> 
>> It catch - It will not allow you to integrate until you resolve "Integration blockers".
>> 
>> Yes, it would be better if Skara does not allow to create such PR but I am not sure Skara does these checks at that time.
>
>> > > @afshin-zafari  Please, set correct RFE id number!!!!  See "Integration blockers" and "Issue".
>> > 
>> > 
>> > ow. But Skara bot did not catch this? How strange.
>> 
>> It catch - It will not allow you to integrate until you resolve "Integration blockers".
>> 
>> Yes, it would be better if Skara does not allow to create such PR but I am not sure Skara does these checks at that time.
> 
> Ah, okay. It would be cool for jcheck to pick this up and show an error in GHAs though. That way you notice it immediately.

@tstuefe and @jdksjolen, if you agree on keeping the method name as it is, then I can integrate this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18000#issuecomment-1970659696


More information about the hotspot-dev mailing list