RFR: JDK-8326974: ODR violation in macroAssembler_aarch64.cpp

[Andrew Dinn]

On Thu, 29 Feb 2024 09:47:11 GMT, Andrew Haley <aph at openjdk.org> wrote:

> This is a slightly different patch from the one suggested by the bug reporter. It doesn't make any sense to export those classes globally, so I've given them internal linkage.

Egad! the action failure messages on Windows include this:

Linking jvm.dll
jvm.exp : error LNK2001: unresolved external symbol "const `anonymous namespace'::Decoder::`vftable'" (??_7Decoder@?A0xe77b3496@@6B@)
jvm.exp : error LNK2001: unresolved external symbol "const `anonymous namespace'::Patcher::`vftable'" (??_7Patcher@?A0xe77b3496@@6B@)

So, clearly something in the guts of the (Windows) build does not like anonymous name spaces.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18056#issuecomment-1971152071