RFR: JDK-8326974: ODR violation in macroAssembler_aarch64.cpp [v2]

[Aleksey Shipilev]

On Thu, 29 Feb 2024 16:04:03 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> This is a slightly different patch from the one suggested by the bug reporter. It doesn't make any sense to export those classes globally, so I've given them internal linkage.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8326974: ODR violation in macroAssembler_aarch64.cpp

Looks fine.

src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 151:

> 149: //       110___10100 (i.e. requires insn[31:21] == 11010010100)
> 150: //
> 151: 

Is this newline addition necessary?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18056#pullrequestreview-1909411315
PR Review Comment: https://git.openjdk.org/jdk/pull/18056#discussion_r1507901707