RFR: JDK-8326974: ODR violation in macroAssembler_aarch64.cpp [v2]

Andrew Dinn adinn at openjdk.org
Thu Feb 29 17:09:53 UTC 2024


On Thu, 29 Feb 2024 16:04:03 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> This is a slightly different patch from the one suggested by the bug reporter. It doesn't make any sense to export those classes globally, so I've given them internal linkage.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8326974: ODR violation in macroAssembler_aarch64.cpp

Also looks good. If the actions fail with this version then surely it has to be a case of "Houston we have a problem  . . . with the actions".

-------------

PR Review: https://git.openjdk.org/jdk/pull/18056#pullrequestreview-1909431552


More information about the hotspot-dev mailing list