RFR: JDK-8326974: ODR violation in macroAssembler_aarch64.cpp [v2]

Andrew Haley aph at openjdk.org
Thu Feb 29 17:16:05 UTC 2024


On Thu, 29 Feb 2024 16:57:44 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8326974: ODR violation in macroAssembler_aarch64.cpp
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 151:
> 
>> 149: //       110___10100 (i.e. requires insn[31:21] == 11010010100)
>> 150: //
>> 151: 
> 
> Is this newline addition necessary?

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18056#discussion_r1507922145


More information about the hotspot-dev mailing list