RFR: JDK-8326974: ODR violation in macroAssembler_aarch64.cpp [v3]

Dean Long dlong at openjdk.org
Thu Feb 29 23:20:52 UTC 2024


On Thu, 29 Feb 2024 17:16:04 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> This is a slightly different patch from the one suggested by the bug reporter. It doesn't make any sense to export those classes globally, so I've given them internal linkage.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8326974: ODR violation in macroAssembler_aarch64.cpp

How about making Decoder into a nested class of MacroAssembler?  You just need a forward declaration in macroAssembler_aarch64.hpp.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18056#issuecomment-1972134435


More information about the hotspot-dev mailing list