Integrated: 8237842: Separate definitions for default cache line and padding sizes

Aleksey Shipilev shade at openjdk.org
Thu Jan 4 08:42:23 UTC 2024


On Tue, 5 Dec 2023 11:23:31 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> [JDK-8321137](https://bugs.openjdk.org/browse/JDK-8321137) needs a clean separation between cache line sizes and padding sizes. At least on x86, there is a wrinkle with "assuming" the cache line size is 128 bytes to cater for prefetchers. Cleanly separating cache line size and padding size resolves this. I rewrote uses of `DEFAULT_CACHE_LINE_SIZE` in padding contexts to new macro.
> 
> The goal for this patch is to avoid actual values changes as much as possible. One of the changes come from cleaning up some of the old cases in x86 definition, thus simplifying the definition. I think the LP64 split is still useful there.
> 
> Additional testing:
>  - [x] Large build matrix of server/zero builds
>  - [x] Linux AArch64 server fastdebug, `tier{1,2}`
>  - [x] Linux x86_64 server fastdebug, `tier{1,2}`

This pull request has now been integrated.

Changeset: dd517c64
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/dd517c64047705d706b095d15d9fd4e0703ab39b
Stats:     99 lines in 25 files changed: 27 ins; 15 del; 57 mod

8237842: Separate definitions for default cache line and padding sizes

Reviewed-by: stefank, kvn, stuefe, tschatzl

-------------

PR: https://git.openjdk.org/jdk/pull/16973


More information about the hotspot-dev mailing list