RFR: 8320069: RISC-V: Add Zcb instructions [v5]
Vladimir Kempik
vkempik at openjdk.org
Fri Jan 5 10:36:24 UTC 2024
On Fri, 5 Jan 2024 09:33:35 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, this is the instructions for zcb.
>>
>> Due to over lack of infrastructure having multiple extension dependent instruction does not fit well.
>> Some of these compressed instructions are also missing 1 to 1 mapping, e.g. now we have a compressed not, but the corresponding instruction in uncompressed is still xor.
>> I think we need to do some rework here.
>>
>> I also I don't like the macro expansion as it hopeless in debugger and 'IDE's (vim+rtags for me).
>> (macro stuff was originally done when templates where blacklisted in hotspot)
>>
>> And I don't want an option for this, as zcb is coming in hwprobe, if you have compressed on you get them if they are supported (may depend on e.g. zbb).
>>
>> I have done some modification since it passed tier1, so I'm running stuff over the weekend.
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>
> Review fixes
Marked as reviewed by vkempik (Committer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/17122#pullrequestreview-1805709077
More information about the hotspot-dev
mailing list