RFR: 8322880: Eliminate -Wparentheses warnings in arm32 code

Kim Barrett kbarrett at openjdk.org
Mon Jan 8 09:34:31 UTC 2024


Please review this change to eliminate some -Wparentheses warnings. In most
cases, this involved simply adding a few parentheses to make some implicit
operator precedence explicit. Exceptions are:

In the clear_array instruct, removed extraneous parens in a declaration:
`Label(loop);` => `Label loop;`

In NativeMovConstReg::set_data, changed `&` => `&&`.  This is conceptually a
bug fix, but the old code "accidentally" worked.

Testing: Local (linux-x64) cross-build for linux-arm32.  Also ran GHA with
-Wparentheses enabled along with this and other changes needed to make that
work.

-------------

Commit messages:
 - Fix -Wparentheses warnings in arm32 code

Changes: https://git.openjdk.org/jdk/pull/17300/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17300&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8322880
  Stats: 13 lines in 6 files changed: 0 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/17300.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17300/head:pull/17300

PR: https://git.openjdk.org/jdk/pull/17300


More information about the hotspot-dev mailing list