RFR: 8321137: Reconsider ICStub alignment [v2]

[Aleksey Shipilev]

On Sat, 6 Jan 2024 01:00:58 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Inline new_ic_stub
>
> src/hotspot/share/code/icBuffer.cpp line 229:
> 
>> 227:            p2i(ic_stub), p2i(ic_stub->code_begin()), p2i(rev_stub));
>> 228:   }
>> 229: #endif
> 
> I think this sanity check would fit better in `new_ic_stub`().

Problem is, `new_ic_stub` can return null on out of memory, so we would need to check that. But I think `new_ic_stub` does not carry its weight, so I just inlined it in new commit, which looks like a good middle ground?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17277#discussion_r1444357650