RFR: 8322880: Eliminate -Wparentheses warnings in arm32 code

David Holmes dholmes at openjdk.org
Tue Jan 9 08:23:25 UTC 2024


On Mon, 8 Jan 2024 09:29:38 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to eliminate some -Wparentheses warnings. In most
> cases, this involved simply adding a few parentheses to make some implicit
> operator precedence explicit. Exceptions are:
> 
> In the clear_array instruct, removed extraneous parens in a declaration:
> `Label(loop);` => `Label loop;`
> 
> In NativeMovConstReg::set_data, changed `&` => `&&`.  This is conceptually a
> bug fix, but the old code "accidentally" worked.
> 
> Testing: Local (linux-x64) cross-build for linux-arm32.  Also ran GHA with
> -Wparentheses enabled along with this and other changes needed to make that
> work.

Looks good. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17300#pullrequestreview-1810617098


More information about the hotspot-dev mailing list