Integrated: 8322880: Eliminate -Wparentheses warnings in arm32 code
Kim Barrett
kbarrett at openjdk.org
Tue Jan 9 22:30:18 UTC 2024
On Mon, 8 Jan 2024 09:29:38 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this change to eliminate some -Wparentheses warnings. In most
> cases, this involved simply adding a few parentheses to make some implicit
> operator precedence explicit. Exceptions are:
>
> In the clear_array instruct, removed extraneous parens in a declaration:
> `Label(loop);` => `Label loop;`
>
> In NativeMovConstReg::set_data, changed `&` => `&&`. This is conceptually a
> bug fix, but the old code "accidentally" worked.
>
> Testing: Local (linux-x64) cross-build for linux-arm32. Also ran GHA with
> -Wparentheses enabled along with this and other changes needed to make that
> work.
This pull request has now been integrated.
Changeset: e9f7db30
Author: Kim Barrett <kbarrett at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e9f7db304559cbc8e2b46ea30496d3c570569f4c
Stats: 13 lines in 6 files changed: 0 ins; 0 del; 13 mod
8322880: Eliminate -Wparentheses warnings in arm32 code
Reviewed-by: shade, dholmes
-------------
PR: https://git.openjdk.org/jdk/pull/17300
More information about the hotspot-dev
mailing list