RFR: 8322179: RISC-V: Implement SHA-1 intrinsic [v3]
Hamlin Li
mli at openjdk.org
Thu Jan 11 10:15:23 UTC 2024
On Wed, 10 Jan 2024 03:02:09 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> round 1 review
>
> Simply ran `micro:java.security.MessageDigests` JMH on my Lichee-pi-4a board, seems there is a small regression for the `MessageDigests.getAndDigest` (length = 64) case:
>
>
> Before:
> MessageDigests.digest SHA-1 64 DEFAULT thrpt 15 417.311 ? 2.686 ops/ms
> MessageDigests.digest SHA-1 16384 DEFAULT thrpt 15 5.206 ? 0.008 ops/ms
> MessageDigests.getAndDigest SHA-1 64 DEFAULT thrpt 15 404.769 ? 14.810 ops/ms
> MessageDigests.getAndDigest SHA-1 16384 DEFAULT thrpt 15 5.106 ? 0.046 ops/ms
>
> After:
> MessageDigests.digest SHA-1 64 DEFAULT thrpt 15 518.057 ? 5.935 ops/ms
> MessageDigests.digest SHA-1 16384 DEFAULT thrpt 15 5.569 ? 0.009 ops/ms
> MessageDigests.getAndDigest SHA-1 64 DEFAULT thrpt 15 378.184 ? 37.425 ops/ms
> MessageDigests.getAndDigest SHA-1 16384 DEFAULT thrpt 15 5.515 ? 0.017 ops/ms
@RealFYang My bad, I think I added some options in my test scripts accidently, which cause the perf data is not right.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17130#issuecomment-1886781509
More information about the hotspot-dev
mailing list