RFR: 8316930: HotSpot should use noexcept instead of throw() [v2]

Kim Barrett kbarrett at openjdk.org
Thu Jan 11 13:12:55 UTC 2024


On Tue, 26 Sep 2023 07:29:18 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> > The change from `throw()` to `noexcept` seems reasonable though I assume we have to first approve this via the Hostpot style guide?
> > There are places you are adding `noexcept` when there is no `throw()` and that seems inappropriate for this PR - unless they are required because of some transitive rule application?
> > Thanks.
> 
> Oops, those places where noexcept slipped through are from an experimental branch where I enabled exceptions for HotSpot, they got in by mistake, my apologies. I've moved this to draft for now, since Apple Clang seems to be having a hard time with the noexcept specifiers. Not sure about the Style Guide, maybe I should ask @kimbarrett?

I've added https://bugs.openjdk.org/browse/JDK-8255082 as a blocker for this bug.  As noted there, addressing that
is not as simple as just saying "yes, we can use noexcept".

And no, we're not going to enable exceptions in HotSpot.

I'd be interested in hearing what problems you've run into with Apple clang wrto noexcept.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15910#issuecomment-1740158526


More information about the hotspot-dev mailing list