RFR: 8316930: HotSpot should use noexcept instead of throw() [v2]
David Holmes
dholmes at openjdk.org
Thu Jan 11 13:12:54 UTC 2024
On Tue, 26 Sep 2023 03:50:14 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> throw() has been deprecated since C++11 alongside dynamic exception specifications, we should replace all instances of it with noexcept to prepare HotSpot for later versions of C++
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>
> Nevermind, this looks better
The change from `throw()` to `noexcept` seems reasonable though I assume we have to first approve this via the Hostpot style guide?
There are places you are adding `noexcept` when there is no `throw()` and that seems inappropriate for this PR - unless they are required because of some transitive rule application?
Thanks.
I will ping @kimbarrett internally.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15910#pullrequestreview-1643532848
PR Comment: https://git.openjdk.org/jdk/pull/15910#issuecomment-1738360697
More information about the hotspot-dev
mailing list