Integrated: 8321137: Reconsider ICStub alignment

[Aleksey Shipilev]

On Fri, 5 Jan 2024 11:32:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> This continues from #16911. It initially started as performance optimization to compact `ICStubs`, but I think the safety arguments for fitting the `ICStub` per instruction cache line prevails. See bug and previous PR for more gory details. The footprint improvements on some architectures come as side-effect of untying the `ICStub` size from `CodeEntryAlignment` to (sometimes lower) cache line size.
> 
> Note that the size of `ICStub` is important, because `ICBuffer` is small (10K by default), and its depletion causes the `ICBufferFull` safepoint. I would make a (separate) argument to bump the default `ICBuffer` size a bit to make it less important.
> 
> Current patch affects `ICStub` size in different ways on different platforms, since current size is effectively 2x`CodeEntryAlignment` and new size is cache line size:
>  - ARM32: 32 -> 64 bytes :(
>  - AArch64: 128 -> 64 bytes :)
>  - x86_64: 64 -> 64 bytes :|
>  - x86_32: 32 -> 64 bytes :(
>  - PPC64: 512 -> 128 bytes :))
>  - RISC-V: 128 -> 64 bytes :)
>  - S390X: 128 -> 256 bytes :(
>  - Zero: <not applicable, Zero does not use IC stubs>
> 
> Additional testing:
>  - [x] Linux x86_64 server fastdebug, `tier{1,2,3,4}`
>  - [x] Linux AArch64 server fastdebug, `tier{1,2,3,4}`

This pull request has now been integrated.

Changeset: 7be9f1d0
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7be9f1d0540907f82800e717389bc3c2da3a8805
Stats:     74 lines in 6 files changed: 39 ins; 16 del; 19 mod

8321137: Reconsider ICStub alignment

Reviewed-by: dlong, eosterlund, mdoerr, fyang, aph

-------------

PR: https://git.openjdk.org/jdk/pull/17277