RFR: 8306767: Concurrent repacking of extra data in MethodData is potentially unsafe [v19]

[Emanuel Peter]

On Wed, 17 Jan 2024 16:15:39 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improved comment for Roland
>
> src/hotspot/share/runtime/mutexLocker.hpp line 271:
> 
>> 269:     NoSafepointMutexLocker(mutex, true, flag) {}
>> 270: };
>> 271: 
> 
> Don't add this.  The locks that are no-safepoint-check-flags have implicit NoSafepointVerifier logic when you take them out.

Ah ok. Thanks for the hint. I will look into this. It is a bit confusing what the locks do and do not do with SafePoints. Do they just not safepoint when trying to acquire the lock, or also verify that no safepoint is made while holding the lock?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16840#discussion_r1455987948