RFR: 8306767: Concurrent repacking of extra data in MethodData is potentially unsafe [v19]

Emanuel Peter epeter at openjdk.org
Thu Jan 18 15:21:18 UTC 2024


On Wed, 17 Jan 2024 16:24:20 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improved comment for Roland
>
> src/hotspot/share/code/compiledMethod.cpp line 698:
> 
>> 696:     print_code_on(&ss);
>> 697:     print_pcs_on(&ss);
>> 698:     tty->print("%s", ss.as_string()); // print all at once
> 
> It seems like these ttyLocker changes should be checked in as a different cleanup, ie removing ttyLocker is a really good thing.  Can you make these changes a separate patch?

Yes, I filed the RFE:
[JDK-8324129](https://bugs.openjdk.org/browse/JDK-8324129) C2: Remove some ttyLocker usages in preparation for JDK-8306767
https://github.com/openjdk/jdk/pull/17486

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16840#discussion_r1457593680


More information about the hotspot-dev mailing list