RFR: 8324186: AARCH64: Use "dmb.ishst+dmb.ishld" for release barrier [v2]
kuaiwei
duke at openjdk.org
Tue Jan 23 15:38:30 UTC 2024
On Mon, 22 Jan 2024 10:13:05 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix for review comments
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 2069:
>
>> 2067: if (last != nullptr && nativeInstruction_at(last)->is_Membar() && prev == last) {
>> 2068: NativeMembar *bar = NativeMembar_at(prev);
>> 2069: // We need avoid promoting barrier to dmb.ish,
>
> Suggestion:
>
> // Don't promote DMB ST|DMB LD to DMB (a full barrier) because
> // doing so would introduce a StoreLoad which the caller did not
> // intend.
>
> I think that should be clear enough.
Thanks for comments. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17511#discussion_r1463469822
More information about the hotspot-dev
mailing list