RFR: 8324242: Avoid null check for OopHandle::ptr_raw() [v2]

Kim Barrett kbarrett at openjdk.org
Tue Jan 23 19:03:29 UTC 2024


On Tue, 23 Jan 2024 11:22:12 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> > Looks reasonable.
> > I guess the use in `ClassLoaderData::remove_handle` is fine, because we want to assert it?
> 
> I forgot about this one. I initially skipped it because I didn't understand what was happening here. I'd forgotten that the CLD uses OopHandle to wrap a pointer to the CLD handle area rather than an OopStorage entry. I'll push a fix after I've run tests.

Non-assert code now just uses is_empty.  However, the assert has to use ptr_raw, unfortunately.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17510#issuecomment-1906735569


More information about the hotspot-dev mailing list