RFR: 8319799: Recursive lightweight locking: x86 implementation [v12]

Coleen Phillimore coleenp at openjdk.org
Tue Jan 23 19:03:34 UTC 2024


On Fri, 19 Jan 2024 22:00:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> It is a little bit awkward that they both have to restore the held monitor count.
>
> Ok, I've looked at the control flow more, which is not simple.  Both have the slow path continuation() exit, and only the exiting with a successor has the unlocked exit.  Can you rename continuation() to slow_path() because continuation doesn't help.

Thanks for renaming continuation function.  I didn't see that the name comes from the C2CodeStub.  this looks better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16607#discussion_r1463849018


More information about the hotspot-dev mailing list